Skip to content

Link to the time-units doc in S3 repository docs instead of explaining it in words#93351

Merged
fcofdez merged 2 commits intoelastic:mainfrom
fcofdez:s3-time-units
Jan 31, 2023
Merged

Link to the time-units doc in S3 repository docs instead of explaining it in words#93351
fcofdez merged 2 commits intoelastic:mainfrom
fcofdez:s3-time-units

Conversation

@fcofdez
Copy link
Contributor

@fcofdez fcofdez commented Jan 30, 2023

No description provided.

@fcofdez fcofdez added >docs General docs changes :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Meta label for distributed team. v8.7.0 labels Jan 30, 2023
@fcofdez fcofdez requested a review from DaveCTurner January 30, 2023 16:55
@github-actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Jan 30, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but I think we should specify the type for every setting on the page, it's a bit odd just to annotate one like this.

@fcofdez fcofdez requested a review from DaveCTurner January 31, 2023 08:14
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fcofdez fcofdez merged commit da387b4 into elastic:main Jan 31, 2023
mark-vieira pushed a commit to mark-vieira/elasticsearch that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes Team:Distributed Meta label for distributed team. Team:Docs Meta label for docs team v8.7.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants